Skip to content

Foreign Keys action#7175

Merged
labkey-adam merged 1 commit intorelease25.11-SNAPSHOTfrom
25.11_fb_fk_report
Nov 6, 2025
Merged

Foreign Keys action#7175
labkey-adam merged 1 commit intorelease25.11-SNAPSHOTfrom
25.11_fb_fk_report

Conversation

@labkey-adam
Copy link
Contributor

Rationale

Developer action that could be helpful when investigating database performance problems. For now, simply reports all incoming foreign keys grouped by target table.

@labkey-adam labkey-adam self-assigned this Nov 5, 2025
Copy link
Contributor

@labkey-jeckels labkey-jeckels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Should we add a link to this (and potentially other) reports. Maybe from the Admin Console?
  2. Should we add a minimal automated test that hits this action and checks for a few expected FKs?

@labkey-adam
Copy link
Contributor Author

  1. Should we add a link to this (and potentially other) reports. Maybe from the Admin Console?
  2. Should we add a minimal automated test that hits this action and checks for a few expected FKs?

My thought is no and no. Though I could be convinced otherwise.

Traditionally, the DevTools module is for internal developers only. We haven't put these actions into the Admin Console or written tests for them, since the module is never installed on client servers. We can change that "rule," but, if so, we should probably add all these actions (and the TestController actions?) to the Admin Console and write tests for all of them.

@labkey-jeckels
Copy link
Contributor

  1. Should we add a link to this (and potentially other) reports. Maybe from the Admin Console?
  2. Should we add a minimal automated test that hits this action and checks for a few expected FKs?

My thought is no and no. Though I could be convinced otherwise.

Traditionally, the DevTools module is for internal developers only. We haven't put these actions into the Admin Console or written tests for them, since the module is never installed on client servers. We can change that "rule," but, if so, we should probably add all these actions (and the TestController actions?) to the Admin Console and write tests for all of them.

OK. Maybe a good future entry point to testing some of these will be to add coverage that ensures that we have the right FKs or indices in place

@labkey-adam
Copy link
Contributor Author

  1. Should we add a link to this (and potentially other) reports. Maybe from the Admin Console?
  2. Should we add a minimal automated test that hits this action and checks for a few expected FKs?

My thought is no and no. Though I could be convinced otherwise.
Traditionally, the DevTools module is for internal developers only. We haven't put these actions into the Admin Console or written tests for them, since the module is never installed on client servers. We can change that "rule," but, if so, we should probably add all these actions (and the TestController actions?) to the Admin Console and write tests for all of them.

OK. Maybe a good future entry point to testing some of these will be to add coverage that ensures that we have the right FKs or indices in place

Agreed

@labkey-adam labkey-adam merged commit 9b42171 into release25.11-SNAPSHOT Nov 6, 2025
8 of 11 checks passed
@labkey-adam labkey-adam deleted the 25.11_fb_fk_report branch November 6, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants